Fix flask effect tooltips and onslaught flask effect calculation (#5743)

Recent change added actorCondition = player to flask effect but this wasnt accounted for in these 2 scenarios. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
PathOfBuildingCommunity · Mar 2, 2023 · 567663a · 567663a
1 parent 8dbb87d
commit 567663a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/Classes/ItemsTab.lua b/src/Classes/ItemsTab.lua
@@ -3097,10 +3097,10 @@ function ItemsTabClass:AddItemTooltip(tooltip, item, slot, dbMode)
 		local modDB = self.build.calcsTab.mainEnv.modDB
 		local output = self.build.calcsTab.mainOutput
 		local durInc = modDB:Sum("INC", nil, "FlaskDuration")
-		local effectInc = modDB:Sum("INC", nil, "FlaskEffect")
+		local effectInc = modDB:Sum("INC", { actor = "player" }, "FlaskEffect")
 
 		if item.rarity == "MAGIC" and not item.base.flask.life and not item.base.flask.mana then
-			effectInc = effectInc + modDB:Sum("INC", nil, "MagicUtilityFlaskEffect")
+			effectInc = effectInc + modDB:Sum("INC", { actor = "player" }, "MagicUtilityFlaskEffect")
 		end
 
 		if item.base.flask.life or item.base.flask.mana then

diff --git a/src/Modules/CalcPerform.lua b/src/Modules/CalcPerform.lua
@@ -945,9 +945,9 @@ local function doActorMisc(env, actor)
 				if item.baseName:match("Silver Flask") then
 					onslaughtFromFlask = true
 
-					local curFlaskEffectInc = item.flaskData.effectInc + modDB:Sum("INC", nil, "FlaskEffect")
+					local curFlaskEffectInc = item.flaskData.effectInc + modDB:Sum("INC", { actor = "player" }, "FlaskEffect")
 					if item.rarity == "MAGIC" then
-						curFlaskEffectInc = curFlaskEffectInc + modDB:Sum("INC", nil, "MagicUtilityFlaskEffect")
+						curFlaskEffectInc = curFlaskEffectInc + modDB:Sum("INC", { actor = "player" }, "MagicUtilityFlaskEffect")
 					end
 
 					if flaskEffectInc < curFlaskEffectInc / 100 then