Skip to content

Commit

Permalink
Fix War Banner not granting damage to Bleed (#7799)
Browse files Browse the repository at this point in the history
I incorrectly applied to the Phys damage bonus to melee damage instead of melee skills

Co-authored-by: LocalIdentity <localidentity2@gmail.com>
  • Loading branch information
LocalIdentity and LocalIdentity authored Jul 22, 2024
1 parent 6067fe9 commit 8da8e39
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion src/Data/Skills/act_str.lua
Original file line number Diff line number Diff line change
Expand Up @@ -11296,7 +11296,7 @@ skills["BloodstainedBanner"] = {
mod("Accuracy", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" })
},
["physical_damage_+%"] = {
mod("PhysicalDamage", "MORE", nil, ModFlag.Melee, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }),
mod("PhysicalDamage", "MORE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }, { type = "SkillType", skillType = SkillType.Melee }),
},
},
baseFlags = {
Expand Down
4 changes: 2 additions & 2 deletions src/Export/Skills/act_str.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2035,8 +2035,8 @@ local skills, mod, flag, skill = ...
["accuracy_rating_+%"] = {
mod("Accuracy", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" })
},
["physical_damage_taken_+%"] = {
mod("PhysicalDamageTaken", "INC", nil, 0, 0, { type = "GlobalEffect", effectType = "AuraDebuff" })
["physical_damage_+%"] = {
mod("PhysicalDamage", "MORE", nil, 0, 0, { type = "GlobalEffect", effectType = "Aura" }, { type = "Condition", var = "BannerPlanted" }, { type = "SkillType", skillType = SkillType.Melee }),
},
},
#baseMod skill("radius", 24)
Expand Down

0 comments on commit 8da8e39

Please sign in to comment.