Skip to content

Commit

Permalink
Hide config options that can be hidden by default behind conditions
Browse files Browse the repository at this point in the history
Config changes:

- Remove "Is your Crit Chance Lucky?" - The only sources can already be
  enabled with existing conditions and the lucky is implied after that
  (Blood Sacrament, Focus Mod, Dance with Death)
- Only show "# of times skill has chained" if there is condition behind
  it (Gloomfang for example)
- Only show "# of times skill has pierced" if there is condition behind
  it (Drillneck for example)
- Only show "melee distance to enemy" if there is stat that depends on
  melee proximity (Close Combat, Slayer for example)
- Only show "projectile travel distance if there is stat that depends on
  distance ramp (Point Blank, Longshot for example)
- Only show "is enemy bleeding" if there is condition behind it
  (Bloodletting for example)
- Only show "# of poison on enemy" if there is condition behind it (Vile
  Toxins for example)A
- Only show "is the enemy maimed" if there is condition behind it (Maim
  support for example)
- Only show "is enemy burning" if there is condition behind it
- Only show "is enemy ignited" if there is condition behind it
  (Snowforged for example)
- Only show "is enemy frozen" if there is condition behind it
  (NOTE: currently does nothing because its default condition in
  calcsetup)
- Only show "effect of shock" if enemy is shocked
- Only show "is enemy on consecrated ground" if there is condition
  behind it (Bottled Faith for example)
- Only show "disable ehp gain on block" if there are any on block
  effects
- Only show "life regen mode" if there is effect that depends on it (Enduring Cry etc)
- Only show "armour calculation mode" if there is effect that depends on it (armour mastery etc)
- Only show "enemy corpse life" if there is skill that depends on it
  (Cremation, Detonate Dead)

New functionality:

- ifStat and ifEnemyStat for PerStat and StatCondition config checks
- ifTagType for tag type config checks
- if SkillData for skill data config checks
- config tab now supports multiple if checks at once
- Replaced all ifXList with support for type checking the value so if value is list it will be treated as list of OR checks. This works for all ifX conditions in config tab instead of only specific ones that had list support before

Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
  • Loading branch information
deathbeam committed Feb 25, 2023
1 parent 7127369 commit af4f947
Show file tree
Hide file tree
Showing 5 changed files with 340 additions and 189 deletions.
Loading

0 comments on commit af4f947

Please sign in to comment.