Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use the generalised mastery count types instead of special life mastery data #5965

Closed
1 task done
QuickStick123 opened this issue Apr 7, 2023 · 2 comments · Fixed by #6041
Closed
1 task done

Use the generalised mastery count types instead of special life mastery data #5965

QuickStick123 opened this issue Apr 7, 2023 · 2 comments · Fixed by #6041
Labels
enhancement New feature, calculation, or mod good first issue Good for newcomers technical Hidden from release notes

Comments

@QuickStick123
Copy link
Contributor

Check for duplicates

  • I've checked for duplicate issues by using the search function of the issue tracker

Is your feature request related to a problem?

Added in #5843

When 6 life masteries stat was implemented it was done by adding code everywhere masteries are counted.
This can simply be retrieved from this array instead of the other unnecessary code.
image

Describe the solution you'd like

Delete explicit life mastery counting and use that array instead.

Describe alternatives you've considered

No response

Additional context

No response
@QuickStick123 QuickStick123 added enhancement New feature, calculation, or mod technical Hidden from release notes good first issue Good for newcomers labels Apr 7, 2023
@mortentc
Copy link
Contributor

Just to be sure, is the idea to replace allocatedLifeMasteryCount on line 579 with allocatedMasteryTypes["Life Mastery"], and then delete all references to allocatedLifeMasteryCount?

mortentc added a commit to mortentc/PathOfBuilding that referenced this issue Apr 12, 2023
@mortentc
Resolution of PathOfBuildingCommunity#5965
49a7170
mortentc added a commit to mortentc/PathOfBuilding that referenced this issue Apr 12, 2023
@mortentc
Resolution of PathOfBuildingCommunity#5965
aa7fbaa
@QuickStick123
Copy link
Contributor Author

Yes

@mortentc mortentc mentioned this issue Apr 13, 2023
Merged
mortentc added a commit to mortentc/PathOfBuilding that referenced this issue Apr 14, 2023
@mortentc
Resolution of PathOfBuildingCommunity#5965
2114989
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod good first issue Good for newcomers technical Hidden from release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Generalise count types mortentc/PathOfBuilding
2 participants
@QuickStick123 @mortentc