Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix session IDs not saving separately per imported account #5357

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

Wires77
Copy link
Member

@Wires77 Wires77 commented Dec 15, 2022

Description of the problem being solved:

Previously, session IDs were saved separately per account you were importing from. When we changed to saving a single session ID globally, we broke that functionality. This PR restores the original functionality, but (currently) at the cost of persisting the trade session ID to the import tab. This is because we don't necessary know if the user is importing from the same account they've used to populate the trade modal

Steps taken to verify a working solution:

  • Create another PoE account
  • Set the characters on your main account to private
  • Import characters from your main account
  • Import characters from your new account
  • You should be able to see characters from both accounts and freely swap between them without having to re-enter your session ID

Link to a build that showcases this PR:

N/A

@Wires77 Wires77 added the bug Something isn't working label Dec 15, 2022
@Wires77 Wires77 changed the title Session id import Fix session IDs not saving separately per account Dec 15, 2022
@Wires77 Wires77 changed the title Fix session IDs not saving separately per account Fix session IDs not saving separately per imported account Dec 15, 2022
@LocalIdentity LocalIdentity merged commit db89bbc into PathOfBuildingCommunity:dev Dec 15, 2022
@Wires77 Wires77 deleted the session_id_import branch February 8, 2023 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants