Critical cull chance uses hit rate #5378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewbelu
changed the title
LocalIdentity
approved these changes
Dec 19, 2022
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 26, 2022
* critical cull chance uses hit rate * Move lines Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Critical cull chance was using just critical strike chance before. This should be based on hit rate because we are measuring DPS rather than a single hit.
Steps taken to verify a working solution:
Ensure that culling critical strikes take hit rate into account
Link to a build that showcases this PR:
https://pastebin.com/C97LKLP7
Before screenshot:
After screenshot: