Add support for repeat-based modifiers #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Might be nice to implement vaal flicker here as well if not to hard. |
Comment on lines
+1908
to
+1910
| if env.configInput.repeatMode == "FINAL" or skillModList:Flag(nil, "OnlyFinalRepeat") then | ||
| skillData.dpsMultiplier = skillData.dpsMultiplier / (output.Repeats or 1) | ||
| end |
There was a problem hiding this comment.
Suggested change
| if env.configInput.repeatMode == "FINAL" or skillModList:Flag(nil, "OnlyFinalRepeat") then | |
| skillData.dpsMultiplier = skillData.dpsMultiplier / (output.Repeats or 1) | |
| end | |
| if env.configInput.repeatMode == "FINAL" or skillModList:Flag(nil, "OnlyFinalRepeat") then | |
| skillData.dpsMultiplier = skillData.dpsMultiplier / (output.Repeats or 1) | |
| end |
This could probably be implemented using hitTimeMultipler which would probably make more sense then a dps multiplier
e.g.
if env.configInput.repeatMode == "FINAL" or skillModList:Flag(nil, "OnlyFinalRepeat") then
skillData.hitTimeMultiplier = output.Repeats or 1
end
if skillData.hitTimeOverride and not skillData.triggeredOnDeath then
output.HitTime = skillData.hitTimeOverride
output.HitSpeed = 1 / output.HitTime
--Brands always have hitTimeOverride
if skillCfg.skillName and skillCfg.skillName:match("Brand") then
output.BrandTicks = m_floor(output.Duration * output.HitSpeed)
end
elseif skillData.hitTimeMultiplier and output.Time and not skillData.triggeredOnDeath then
output.HitTime = output.Time * skillData.hitTimeMultiplier
output.HitSpeed = 1 / output.HitTime
end
-- Other Misc DPS multipliers (like custom source)
skillData.dpsMultiplier = ( skillData.dpsMultiplier or 1 ) * ( 1 + skillModList:Sum("INC", cfg, "DPS") / 100 ) * skillModList:More(cfg, "DPS")
end
There was a problem hiding this comment.
This does make more sense to me unless there are issues with it.
|
Fixes #346 |
Wires77
approved these changes
Apr 7, 2023
Comment on lines
+1908
to
+1910
| if env.configInput.repeatMode == "FINAL" or skillModList:Flag(nil, "OnlyFinalRepeat") then | ||
| skillData.dpsMultiplier = skillData.dpsMultiplier / (output.Repeats or 1) | ||
| end |
There was a problem hiding this comment.
This does make more sense to me unless there are issues with it.
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* allow for custom mod dps multiplier * Initial Repeat Improvements * fix missing txt change * implement vaal flicker * fix stack potential with skill dps multiplier * add display for number of repeats in calc sections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
built ontop of #5670
This is more of a stopgap solution, as calc offence requires a full rework to properly calc damage variances and not just averages, but thats not in the near future
This PR allows you to force repeats to do nothing, to average out (default), to only use the final repeat (sets damage to final and dps mults the number of hits down), or to use final damage but without modifying the "dps multiplier"
This also adds support for Plume of Pursuit, Fatal Flourish (Duelist hidden forbidden notable), and the caster mastery
It also fixes the more damage on divergent spell echo (it was being div by 3 instead of averaged by 2) and the interaction between divergent spell echo and greater spell echo, as well as the area granted by greater spell echo and alt qual multistrike