Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting Blood Charges to 0 #5690

Merged

Conversation

Paliak
Copy link
Contributor

@Paliak Paliak commented Feb 17, 2023

Fixes #5657 .

Description of the problem being solved:

Due the the count input being used for Blood Charges input box on the config tab setting the blood charge count to 0 resulted in defaulting to max blood charges.

There also seem to be some off by 1 issues with count boxes due to

elseif key == "WHEELDOWN" or key == "DOWN" then
if cur and (self.filter ~= "%D" or cur > 0)then
self:SetText(tostring(cur - (self.numberInc or 1)), true)
else

But not sure how to properly fix.

@QuickStick123 QuickStick123 added the bug Something isn't working label Feb 17, 2023
@LocalIdentity LocalIdentity merged commit 7092d01 into PathOfBuildingCommunity:dev Feb 18, 2023
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@Paliak Paliak deleted the bloodChargesAllowZerro branch January 20, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect blood charges value
3 participants