Highlight borders for changed config options in config tab #5717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
heres also screenshot with colors on labels from my windows pc (as pobfrontend has bug that do not rly shows them properly) to give the full picture |
|
It is interesting that the custom modifier box also turns blue. Probably not necessary. |
|
Hmm yea I will adjust that when i come home |
deathbeam
force-pushed
the
recolor-changed
branch
from
eaebc82 to
a8312d2
Compare
|
Alright removed the highlighting of custom mods box |
deathbeam
force-pushed
the
recolor-changed
branch
2 times, most recently
from
ffaf9e1 to
70be20d
Compare
deathbeam
force-pushed
the
recolor-changed
branch
from
70be20d to
5273315
Compare
This highlights borders for controls for changed config options when they are in non-default state. Useful for quickly checking what options user configured and prevents forgetting about some config set by accident (dropdowns in non-default state are especially hard to spot) Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
deathbeam
force-pushed
the
recolor-changed
branch
from
5273315 to
c3c8618
Compare
LocalIdentity
approved these changes
Apr 24, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
…ldingCommunity#5717) This highlights borders for controls for changed config options when they are in non-default state. Useful for quickly checking what options user configured and prevents forgetting about some config set by accident (dropdowns in non-default state are especially hard to spot) Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This highlights borders for controls for changed config options when
they are in non-default state. Useful for quickly checking what options
user configured and prevents forgetting about some config set by
accident (dropdowns in non-default state are especially hard to spot).
Description of the problem being solved:
Sometimes its pretty easy to configure something by accident (either via missclick or simply forgetting about configuring it before) and it can be hard to tell if the config is in non-default state or not. Also in bigger pobs it can be sometimes hard to see what is the exact config for the pob. This solves that by subtly highlighting borders of changed config controls.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/5fQaEhtVLtYj
Before screenshot:
After screenshot: