Colorize and group defensive calc sections #5753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deathbeam
force-pushed
the
colors
branch
2 times, most recently
from
f6e949d to
85fa4ef
Compare
There is quite a lot of calc sections now and colours make them easy to quickly recognize from each other. Also group them properly together as "primary", "secondary" and "misc" defenses. Signed-off-by: Tomas Slusny <slusnucky@gmail.com>
LocalIdentity
approved these changes
Mar 31, 2023
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
) There is quite a lot of calc sections now and colours make them easy to quickly recognize from each other. Also group them properly together as "primary", "secondary" and "misc" defenses. Signed-off-by: Tomas Slusny <slusnucky@gmail.com> Co-authored-by: LocalIdentity <31035929+LocalIdentity@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is quite a lot of calc sections now and colours make them easy to quickly recognize from each other.
Also group them properly together as "primary", "secondary" and "misc" defenses.
Description of the problem being solved:
Some of the secionts are split to weird places, for example block and dodge/supp and other damage avoidance is nowhere eachother. And there is a lot of columns currently and sometimes its hard to visually distinguish one from another.
Link to a build that showcases this PR:
Just completely empty pob already showcases it.
Before screenshot:
After screenshot: