Minion Accuracy equals player Accuracy #5808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synotim
commented
Mar 31, 2023
| @@ -1184,7 +1184,11 @@ function calcs.perform(env, avoidCache) | |||
| env.minion.modDB:NewMod("Armour", "BASE", m_floor((10 + env.minion.level * 2) * env.minion.minionData.armour * 1.038 ^ env.minion.level), "Base") | |||
| end | |||
| env.minion.modDB:NewMod("Evasion", "BASE", round((30 + env.minion.level * 5) * 1.03 ^ env.minion.level), "Base") | |||
| env.minion.modDB:NewMod("Accuracy", "BASE", round((17 + env.minion.level / 2) * (env.minion.minionData.accuracy or 1) * 1.03 ^ env.minion.level), "Base") | |||
| if modDB:Flag(nil, "MinionAccuracyEqualsAccuracy") then | |||
| env.minion.modDB:NewMod("Accuracy", "BASE", calcLib.val(modDB, "Accuracy") + calcLib.val(modDB, "Dex") * (modDB:Override(nil, "DexAccBonusOverride") or data.misc.AccuracyPerDexBase), "Player") | |||
There was a problem hiding this comment.
Had to manually account for the dex modifier here unexpectedly - originally incorrectly assumed calcLib.val(modDB, "Accuracy") would get me the final player value.
LocalIdentity
approved these changes
Mar 31, 2023
LocalIdentity
changed the title
Dullson
pushed a commit
to Dullson/PathOfBuilding
that referenced
this pull request
Dec 6, 2023
* Added support for the new minion's accuracy rating is equal to yours mastery * Fix: have to account for accuracy from dex as well
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…mastery
Description of the problem being solved:
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/bSRGKIGq9tCB
Before screenshot:
After screenshot: