Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix skill stages not being editable in some cases #5877

Conversation

QuickStick123
Copy link
Contributor

Description of the problem being solved:

Death wish and a couple other stage skill didn't work as the data was immediately deleted.

Steps taken to verify a working solution:

image

https://pobb.in/fLswXVcfxziw

@QuickStick123 QuickStick123 added the bug Something isn't working label Apr 3, 2023
@Wires77 Wires77 changed the title Do not delete stage data if it is possible a different part needs it Fix skill stages not being editable in some cases Apr 3, 2023
@Wires77 Wires77 merged commit 3c5c4b1 into PathOfBuildingCommunity:dev Apr 3, 2023
@QuickStick123 QuickStick123 deleted the do-not-delete-stage-data-if-it-is-possible-a-different-part-has-it- branch April 6, 2023 01:57
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
…unity#5877)

* Do not delete stage data if it is possible a different part needs it.

* Slight optimisation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants