Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Saboteur Ascendancy #5954

Merged
merged 2 commits into from
Apr 7, 2023
Merged

Add support for Saboteur Ascendancy #5954

merged 2 commits into from
Apr 7, 2023

Conversation

Peechey
Copy link
Contributor

@Peechey Peechey commented Apr 6, 2023 •
edited
Loading

Description of the problem being solved:

Supports the hits dealt portion of Bomb Specialist with an averaged more multiplier.
Supports the less damage with Triggered Spells portion of Perfect Crime

Steps taken to verify a working solution:

Bomb Specialist

  • Allocate Bomb Specialist
  • Add Wave of Conviction
  • Add Righteous Fire
  • Validate WoC has 10% more
  • Validate RF has 0% more

Perfect Crime

  • Allocate Perfect Crime
  • Add wand with trigger craft
  • Add Arc to wand slot
  • Validate Arc has 35% less

Link to a build that showcases this PR:

eNq1W-Fz2joS_9z8FR5m3szdTALYgEMyyXtDSNIyE1IO0vbep46wBehVtqgth9JO__dbSTYYgoyNfe1Ma6z9rXZXu6vVIm7--uFR4xUHIWH-bc2sN2sG9h3mEn9-W_v08njRrf3159nNCPHFx9ldRKgY-fPs3Y18Nih-xfS2ZtUMjoI55p8TTq2vwGmJfL7AzB-if1jwnrm3tWfm45oxRb5LePLJoSgMn5GHb2uTBXLZqmag0MG-208NoCnjOAqAeoEC5HAcPImpexFnQ-YCxQzREJh5iPgT5nzD_H3AoqUU7ZXglSIaDEcfxy8pwYifFgz0enczomiNgwlH3Ajhn9taD8yD5vgD4cAK0Qj4mFb7sn7VuuzUGpmYuygI-T3y4DE_drLE2N2QN-sC0Gx1rW67edlpaVE4gDlfAjKf42CMOC7MYRTgh9kMO5y84n5AeH-BfGfLRitvUdphRDlZUoKDrU3qWsSHN8zNZlNH_MI4ovejyZa206nbltXptrp2q2Vl49h2gbUzfCF8cUdhgU6YRWAHc59wfCJ4xEjI_BL6paFaFfsRpRDkuWjHOAS_Q5zsiqXnzbwp8U-yXp8xCsnB3-C69aZ5paMeIh_1Wbhd0c5lFukIB5Bx-A6ieQQwwQ6DJJWGXNbNZtc0u5Z5ZVlXrRwzHuajnfqJzHB-ykJaxYCi0pymx8MkL11hxqcJNIYUnY9ywiKak5KnMlxbH0Lf04R2V0d4j39sqCytbw18noMKJt0hbFv6WV-ZCO_j6sok8_BhtFUF9rlu07rqdGy709TOMFqsQ-IgOkQ_iBd5kPBf0De8ndC-0vvffMF9yFU6aFtrgEcS4OKoPqSgE1ALxMLiMBFdOYwA5YJzLWgHvpMvZD_5gUzbqSojy8YzPIZAEgXNlOKciO0UcTjm2b3VVHPsx_Ot86nzhLGzeA91327Vk5V8c-wK0qyCNpdZBeEBs2ZvOicZSQAPG8nMghQ00oOPg_l6siCYusWoE7H6aJkjQwojp9G5jL07XSF_SUMLmuQLCtx8-0hBmVRxJjAb2quresvOpH_GfLwDubjqZmCAfBNdKchVNmTja8d9DKjfLEuO5XhFYXpvMe1sT1Hk-SISQ5UOABfvHR-a-vMP-0ecfmgxWC_wWBTk9HVFnEuBZFtUx8cxdiMn3z58R-H8m1d6kIrSQoge58j5ds_cOS40SXHEJFouIUOKJc-LE9s6nElIqjy7sHNQf4RQzZWxRAWQf4Itde4JNjVN_ln2IPl1EXVJAWW25Lmn2DQUhpAMPdjiZHNjyNzU0b-pLY0f4SSa61gpCXMeb0dsBcIvRLsqLEYNJdwGoC8sA-z_XOfmv0Oea4IH340CEQ2559hHHJrmhXiQMMPwHnFkuHHN_xkFBPncEnnfCDEKnMUTrP4jonQKOeC2ln4rPu0BzWTDuGnIdqF4GnhLFnD5so-oE8rZB_4y4oYvW30eCZ2v02g2Ey07mIAHshf58Pj40H8ZfH6IBU5Dwm-E0q9-5E1FT0n9Lzp_inKCZeI0wmgaqsfb2meCVxOBusccEQpGdBilaBlid9NKJPAoaSZgGYdncJNUUNknnb7DvLYEek4PP3DAQV8oNpyAYK1cm_EjQqkJRSEiFljHTXS-9IxUwu-jkKtCSWMp2bXUcxGdP606YjADCz6DqHbmePSIJfh6iUPYgsmMOCI2spf8BagVVYZdHAfCyllnrHe8bel5yFaijoEa1INVO1CHjkczrCpbkVqrqlE9_B47SKu7GtSDN7U382Vf_TCXDVUGp2fmSyeHoOkRKrYY7co-ULwh0TP8yBc4UPuWltMQclRCkhk4AZlGXB_GKYoMW8k-gMZCYkwPVWddjQ5iLCMT7ZwANQZN0-hZqZOTNpFlQVW5obVfXLxkLEFcnGvMr0YzjJCcTzT6x8MZQSLzb--VEVcVsJpw2SPLShhQqpdnI4vx8mz2y_TyHB8pCr9p1zse1cM_wfGN8PUBLjyI8jIRQVWOg4itchzG-4XEFjvOLiFk_rrHMwyGzkxgG5qM9eWRfw-bHM9Y25yspFiHA2GrWiFeKpUf1LQwR-WgcWc2y4cVyRFGsBd9yKh28nHaHJ0-YETFd3-MlmP4pgNdSk_GQ-S7sm1VUlHRKYuWwCyR7OOhcnW7pPtcbxrJQeJG1m6hEcIJ4z32wrs1nAgfxe60980jkoaNi3uujjdpTDKdi2coouL9fyIkEos4ZaXePqnrDz4LvM33F8BqwVYiKSqOopQMYa95elIjPcpjZmK6xF7KOrFAUk1TvotfynsNva3UUmN5uYH4Do1cPPDjw_JmASiaCtnEfQ7RuN-YcI_TZqJ3NyBPTPyesimiVgJJbnk0azvjZjIuz18DUXNGgUhb35V-A1kISlvVjDn2xOchnLdcOGM2Bhy0bwgTNKQc8LSLlqbekx0cxVfLJQ5-oqMmKohXbLCZ0Wf-K1EtskZlCo1FawWzKBStopMVO8wlr4IbtCHhSrkbxfy4i5iHXMQnVO8gIWWi3Y3REgLV_P86TC9wTrZqGpvXlgLzxoDxIwSezCYqiYjHlwDjJFdIuBnHKXxI31ESkraEoUKOg3V8MBCW9ZkrYr_dtrut8_bl5WX33Ozarc65bTXty3Or24Hnrn1VMzhMlbo8ZZnxvSjB2o4zwafxkzL8gvNleN1orFar-hLxBZvhH4TiusO8xhJAIO-FNPGFYNvowZ-7-d_3d0_fSdd_fnVXzxRe3SozJFxv1LWpsBGbBHSU5hBGEA_PDI4pYky8TD5IE4lmStwImvBA6P2TMe9v8aX3Zb3ZbavPca604_wIh-t7ApYK5NacrJkg_O9t7cJsW3a9a6vO4I1c_HghxHOSs6MQq-_4lbPK16l0KkjTqXSMAnCVa2PcGz-cPYPMguBM5A32DbZs4wvsQWf9AM04dq8NIdDZKMAz8uPaENfDMj5MolmeD3Hevzas5lls7Wvj7gL-nknrjPH3a-PSOht4S0ocIkbNs18czcNrV2565x7xwUN-_wqQP8fXzXrn91C-CWFTQtT4l2VftJr__kOEfIARbJyG2i1jLtIpziP_FYO7uF895p470mnPId5-_3KU7r_jW2QGMpSUwEZW-sZqgX1jzSLjU4jFqGRnrAhfwKcu-IBYDCO5qXO2YSjRoRHzBXZ8QUJjhdbGQmRvs9P8w_BYgA1xsUI645C5Y6GjITUVl9g6tXgt4_jVUiR9P5kzNo4gtlW9v-zuuJAADQKY0RSCQ8axbDNCEnsVhaYYEnHZTETRAbY5NIGYxyB3DAorozddhyGspzK_0Skw5x2mfB9vFcDLk4nROkFLY7JCy_2p26cwKqF-zMOqgMdhhewKFLIrUOgkHocUMos41yHvbFVgEasqbYr42wcMJ0heyh4Hgs0uLYFVmEPpKVtV2b9TgTOYFYSHWYEc7YKeUFWKscpGZLsCAxbfMypLsa2y-lslQ7iYAO7aUI3kMj6oaosyHA4Hdqc0B7uqZTWryjHFXbO8Hdul17JTjVMVUb7nRRTzCjJhq4KE0ioZlO2SeLMa-5-8UxZ22nZhxClVVEmrdsrm6oqWpV1Vcqmsrj75CFUANxZtC6t0arKqWYPKdooqDnzt03Qqavzye3xFxUantCDltzi7aDIomzzeTqi6PkkrVzYO5VUz5s_I_M3FMdELIuIrA3nTBNazZkwZoxj5cUPy7V2zAIdgfQeLaym7N9R6nx_GvfeH7qdhH3vrQXjHwnBLLn9x-pbWiULOPOCcIj1Atv_T2qN81W9uj5JJUSfkJx6J3yak6IfYJZGXJUn8W9qDU4wocvCCURcHOxOpn7omN_Yu0z97OEQf34VmlMrWXxqZDUyCe3M30M6mT_-mNcF0jkOSC4AJpHVErM39kgTQPSLX7qXwFC75JjT285vG_i-2_wcp6r12

Before screenshot:

image
image

After screenshot:

image

image

image

image

image

@Peechey Peechey added the enhancement New feature, calculation, or mod label Apr 6, 2023
@Peechey Peechey marked this pull request as draft April 6, 2023 23:26
@Peechey Peechey marked this pull request as ready for review April 6, 2023 23:31
@Wires77 Wires77 merged commit 77082c1 into PathOfBuildingCommunity:dev Apr 7, 2023
@Peechey Peechey deleted the feature/sabo_ascendency branch April 18, 2023 16:27
Dullson pushed a commit to Dullson/PathOfBuilding that referenced this pull request Dec 6, 2023
@Peechey @Dullson
Add support for Saboteur Ascendancy (PathOfBuildingCommunity#5954)
705d9dc 
* support for sabo bomb specialist

* support for sabo perfect crime
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Wires77 Wires77 Wires77 approved these changes

Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Peechey @Wires77