Correct handling of Firesong and Stormshroud #6145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Firesong and Stormshroud both cause a mod for their ailment type to apply to all elemental ailments. This was previously handled through replacing those mods in the modDB. While this worked, it had the side effect of the effect being persistent. Removing the jewels did not make it go away. Replacing the sources of the original stat did not correct it. Exiting and reopening the build did not correct it. The effect also persisted between builds. The only way to reset the effect would be to completely restart PoB.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/6Gyz5yKrhijW