Fix calculation of hybrid mana+life costs #6179
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6008 and fixes #6029.
Description of the problem being solved:
The life mastery with "Skills Cost Life instead of 30% of Mana Mastery" seems to function more akin to:
"Skills gain additional base life cost equal to 30% of base mana cost. Skills cost 30% less total mana."
In-game, this means that the mastery only lessens mana costs after +/- to total mana cost, but adds life cost before any modfiers have taken effect.
Ongoing discussion on whether or not this is intended: https://www.pathofexile.com/forum/view-thread/3369075
Even if it is not inteded, I think PoB should reflect the game's behaviour, and it is possible to revert the change if it turns out to be unintended.
I have also added a mention of the mastery in the breakdown of mana cost.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: