Don't apply energy shield stun avoidance if EB allocated. Add note regarding stun avoidance calcs. #6249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also adds a note informing the user that the values is only applied when ES > Total incoming damage in POB
Paliak
changed the title
LocalIdentity
approved these changes
Aug 13, 2023
LocalIdentity
approved these changes
Aug 13, 2023
|
Thank you so much. You guys are awesome!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6241 .
Description of the problem being solved:
In game having any energy shield when taking a hit grants 50% chance to avoid being stunned. POB only applies this value when ES > totalTakenHit as a way of assuming ES uptime without informing the user.
Allocating the Eldritch Battery keystone stops the chance to avoid from being applied in game. POB applied it without checking if the keystone was allocated.