Fix crash when hovering over life mastery mod. #6252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With no life masteries allocated allocatedMasteryTypes["Life Mastery"] is nil causing the value of the "Multiplier:AllocatedLifeMastery" mod to be nil which causes crash when taking the "10% more Maximum Life if you have at least 6 Life Masteries allocated" into account for calculations.
LocalIdentity
approved these changes
Aug 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6221 .
Description of the problem being solved:
With no life masteries allocated
allocatedMasteryTypes["Life Mastery"]is nil causing the value of theMultiplier:AllocatedLifeMasterymod to be nil which causes a crash when taking the10% more Maximum Life if you have at least 6 Life Masteries allocatedinto account for calculations.Link to a build that showcases this PR:
https://pobb.in/1lP4zWwLfT-l