Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add poeplanner.com tree import ability #6280

Merged
merged 11 commits into from
Sep 9, 2023
Merged

Add poeplanner.com tree import ability #6280

merged 11 commits into from
Sep 9, 2023

Conversation

pHiney
Copy link
Contributor

@pHiney pHiney commented Jul 18, 2023 •
edited
Loading

Fixes #3767

Description of the problem being solved:

Fix my frustration (and maybe someone else's) with:
image
when importing the poe export tree supplied by poeplanner.com

Description of the problem being solved:

Inability to import from poeplanner.com

Note:

  • poeplanner.com url also contains the bandit information. This is commented out. Is there a way to note if this is new build ?
  • There are still debug prints in the code. This is so when someone finds something broken, I can check (more easily) what went wrong.
  • Cluster nodes don't import properly, same as ggg urls.
  • Attempting to decode the minified url (eg: https://poeplanner.com/b/E8I) fails with "We're sorry but PoE Planner doesn't work properly without JavaScript enabled. Please enable it to continue." returned.

Steps taken to verify a working solution:

  • Copy the poeplanner.com url, not the poe export url.
    image
  • Import the tree using the PoB "Import Tree" button as per regular usage.
  • Observe no error, and the tree is displayed, with Masteries if they were part of the import.

Link to a build that showcases this PR:

These are some test links used.

@QuickStick123 QuickStick123 added the enhancement New feature, calculation, or mod label Aug 2, 2023
@LocalIdentity LocalIdentity merged commit 5ab9a7b into PathOfBuildingCommunity:dev Sep 9, 2023
@pHiney pHiney deleted the poeplanner branch September 9, 2023 05:17
shafouz pushed a commit to shafouz/PathOfBuilding that referenced this pull request Dec 8, 2023
@pHiney @shafouz
Add poeplanner.com tree import ability (PathOfBuildingCommunity#6280)
a345752 
* Add poeplanner tree import ability

* Update for v3.22 tree

---------

Co-authored-by: Hiney <pHiney@users.noreply.github.com>
@Wires77 Wires77 mentioned this pull request Dec 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LocalIdentity LocalIdentity LocalIdentity approved these changes

Assignees
No one assigned
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Importing tree causes PassiveSpec.lua:283 AllocateMasteryEffects attempt to index a nil value.
3 participants
@pHiney @LocalIdentity @QuickStick123