Use highest max shock from any active skill, not from main skill #6295
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6243
Description of the problem being solved:
Shock nova has +10% to max effect of shock. However, when using it as a secondary skill, other skills would not be able to set max shock to those 10% higher. This meant that you could not simulate DPS accurately of other skills in situations where your alternate shock nova is able to crit for the max.
This does introduce a potential user error where they use the main skill shock tooltips to try and calculate how much they shock, but there's only so much we can do about that.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/L7s622aSaPUu