Fix Battlemage's Cry and Redblade Banner not working correctly #6301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lilylicious
force-pushed
the
redbladeBannerInfinity
branch
from
0d85bde to
d687a63
Compare
Lilylicious
force-pushed
the
redbladeBannerInfinity
branch
from
d687a63 to
e52898b
Compare
LocalIdentity
approved these changes
Aug 13, 2023
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6208
Description of the problem being solved:
Applying the warcry power overrides in the actor misc section, after a lot of other stuff, caused some issues. Notably, it caused the increased spell damage from Battlemage's Cry to not apply correctly without manually setting warcry power, even when Redblade Banner was equipped.
This just moves said overrides to apply immediately prior to where warcry power is first used.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/2f_873aTBknM