Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on 100% reduced reservation efficiency for relic of the pact #6303

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Data/Skills/other.lua
Original file line number Diff line number Diff line change
Expand Up @@ -359,6 +359,9 @@ skills["BloodSacramentUnique"] = {
castTime = 0.2,
fromItem = true,
initialFunc = function(activeSkill, output)
if output.LifeReservedPercent >= 100 then
return
end
local lifeReservedPercent = activeSkill.skillData["LifeReservedPercent"] or 3
local lifeReserved = activeSkill.skillData["LifeReservedBase"] or math.huge
activeSkill.skillModList:NewMod("Multiplier:ChannelledLifeReservedPercentPerStage", "BASE", lifeReservedPercent, "Blood Sacrament")
Expand Down
3 changes: 3 additions & 0 deletions src/Export/Skills/other.txt
Original file line number Diff line number Diff line change
Expand Up @@ -150,6 +150,9 @@ local skills, mod, flag, skill = ...
#flags spell area
fromItem = true,
initialFunc = function(activeSkill, output)
if output.LifeReservedPercent >= 100 then
return
end
local lifeReservedPercent = activeSkill.skillData["LifeReservedPercent"] or 3
local lifeReserved = activeSkill.skillData["LifeReservedBase"] or math.huge
activeSkill.skillModList:NewMod("Multiplier:ChannelledLifeReservedPercentPerStage", "BASE", lifeReservedPercent, "Blood Sacrament")
Expand Down