Fix Calculation of Ignite/Bleed when at low stacks + show min/max DPS for Ignite/Bleed/Poison #6321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
August 13, 2023 19:35
Changes the formula for stacking ailment calculations as it overvalued lower hit rates too much Also shows a DPS range for Ignites and Bleeds so people can see how
LocalIdentity
added
enhancement
added 2 commits
August 14, 2023 00:20
The roll range would not appear if the baseVal was unmodified, now it always shows up
LocalIdentity
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous formula used for Ignite and Bleed stacking was incorrect and was off by around 15% at low stacks and gradually got closer the higher the stack value
This PR also adds support for showing the min and max DPS values for Ignite and Bleed skills.
It is much more useful for Bleed imo as you can low roll a bleed that deals 20% of your max damage