Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Wait for max unleash seals' mana cost fix #6333

Merged

Conversation

busterw
Copy link
Contributor

@busterw busterw commented Aug 14, 2023

Description of the problem being solved:

  • Mana usage of skills when 'Do you wait for Max Unleash Seals' was increasing mana cost per second rather than reducing it.
    -Example (using the following POB : https://pobb.in/1bHJnA2_Q3Nm):
    • Unchecked:
      image
    • 'Do you wait for Max Unleash Seals' Checked:
      image
  • Inversion of the value is already done to hitTimeOverride earlier on, so inverting the value again (the removal of which is the change I've made) results in the mana cost being higher than it should:
    image

Steps taken to verify a working solution:

Do not invert use speed of max unleash when factoring in cost
@QuickStick123 QuickStick123 added the bug: calculation Numerical differences label Aug 15, 2023
@LocalIdentity LocalIdentity merged commit a899668 into PathOfBuildingCommunity:dev Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants