ux: Add icons to Socket Group skill list based on the item slot #6339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuukk
changed the title
|
I would like to improve this further by detecting the item type for the waepons, so it can display the proper icon (staff, bow, quiver etc) If anyone know how to get that information, please share, that would be very nice of you |
Lilylicious
suggested changes
Aug 18, 2023
added 5 commits
August 19, 2023 03:22
Adds the code to change the weapon based on type, Only uses a bow, quiver and shield as the alternate icon art for slots
LocalIdentity
approved these changes
Sep 9, 2023
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
…OfBuildingCommunity#6339) * Add icons for various item types * Add icon support for ListControl * Display icon based on socket group's slot * Add some padding between text / icon * Fix weapon swap * Remove dev leftover * Change Glove image * Change Shield + Fix loading * Change icons based on weapon type Adds the code to change the weapon based on type, Only uses a bow, quiver and shield as the alternate icon art for slots * Fix colour changing --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5429
Description of the problem being solved:
I was tired of clicking each items to know where they are equipped whenever i import a new build
Now it's properly displayed all at once, so i get a better understanding of where things are
LICENCE for icons: CC0 - https://ashizian.itch.io/2-bits-pack
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Any build will work
Before screenshot:
After screenshot: