Combustion fix when a non-damaging skill precedes a damaging skill #6344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes bug report from reddit.
Description of the problem being solved:
If a non-damaging active skill in a socket group that included combustion was before a damaging active skill, the previous code would try to get the combustion resistance reduction value from the non-damaging skill, which couldn't be supported by Combustion.
By checking for skilltypes attack or damage, we only include active skills that can inflict ignite.
Link to a build that showcases this PR:
https://pobb.in/-T5bbhXkYKbX