Fix uuid collision related issues. #6510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paliak
force-pushed
the
fixUUIDCollision
branch
2 times, most recently
from
74e47df to
444d4bf
Compare
Paliak
force-pushed
the
fixUUIDCollision
branch
from
444d4bf to
ee12819
Compare
LocalIdentity
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6347 Fixes #6509 and issue mentioned on discord.
Description of the problem being solved:
There were many issues caused by uuid collisions which caused trigger function to use incorrect cached data.
Additionally pr prevents on hit curses from being triggered and cleans up dead code most likely left over from the merge.