Misc FullDPS fixes #6566
Merged
Misc FullDPS fixes #6566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 31, 2023
|
Fixes #5286 |
LocalIdentity
approved these changes
Sep 6, 2023
|
Potentially fixes #2831 as I'm unable to reproduce now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6467 and potentially #4666
Description of the problem being solved:
Cost warnings were always calculated even for CALCS and CACHE modes which slowed down heat map generation considerably.
Heat map when in FullDPS mode was incorrectly looking into minion output for full dps variable to compare causing no changes to show up. #6467
I'm not sure what the
forceCachecode implemented in 8fbfe6e was supposed to accomplish but it's causing issues by caching only partially computed skills.Steps taken to verify a working solution: