-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix new trigger calculation #6581
Fix new trigger calculation #6581
Conversation
Add TimeSpan.MIN MAX ZERO constants
This reverts commit d84d9e1.
…/PathOfBuilding into issue/fix-trigger-calc-issue
Quite busy with irl responsibilities, sorry. Playing with the numbers a bit they seem odd. Though the issue i mentioned in the thread seems to be fixed. This may be solved by the unaligned version. This assumes the old sim is correct. The code itself looks fine. I played around with the python sim and the issue seems related to the rather sizable flat steps on the plot. Increasing the count doesn't seem to change those much. |
#7244 is what i ended up going with. I really appreciate the help. Doubt i'd be able to reason about this problem without your help. |
Fixes #6492.
@Paliak Please verify my Lua <3
@KonstantinosKoubetsos I will create another branch with the simulation method we discussed and link the draft later.
Description of the problem being solved:
The previous heuristic used for computing trigger rates was wrong. This replicates the same behaviour as the old by tick simulation.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
Before screenshot:
After screenshot: