Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit Node Depth in Heatmap generation #6598

Merged

Conversation

Subtractem
Copy link
Contributor

New Feature: User selectable limiter on node depth for Node Power heatmap generation.

Description of the problem being solved:

Currently, generating the full heatmap can take multiple minutes for certain builds on slower machines. In the vast majority of cases the user doesn't care about nodes more than a certain distance away from currently allocated nodes. By giving the user a dropdown to choose to only check against nodes with a max distance we can dramatically speed up the operation.

Too much choice seemed frivolous so I went with only 5 and 10 . We could easily expand this to more choices if we wanted. More than 10 is often close to the entire tree anyway for many builds.

Steps taken to verify a working solution:

Generate a Node Power heat map after selecting from the new dropdown to the right of the checkbox on the Tree Tab.

Link to a build that showcases this PR:

All builds will show this functionality, even no build at all.

Before screenshot:

LO6syo9

smziMbK

After screenshot:

uSmm9y9

dMKEmKK

@Subtractem
Copy link
Contributor Author

Discussed with LocalIdentity, I have moved the Import and Export tree buttons to the Manage Trees popup to make room in the TreeTab bar as it is currently overflowing.
H0V5vYo

@IMKoryakin
Copy link

Heya @Subtractem, just wondering why is it a dropdown with just 5 and 10 but not a numericupdown (with min and max values to prevent exceptions)?
May be make steps in that numericupdown like (5,10,15,20...)?
You say its frivolous but I think more options is better than less options :D

When All checkbox is selected - you can probably hide numericupdown to save some space
изображение

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants