Skip to content

Fix crash when using Saviour Mirages in FullDPS #6677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LocalIdentity merged 2 commits into from
Sep 14, 2023
Merged

Fix crash when using Saviour Mirages in FullDPS #6677

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b239408
FIX: crash caused by missing output
Paliak Sep 13, 2023
3fbfd95
FIX: crash caused by order of things
Paliak Sep 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/Modules/CalcMirages.lua
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,7 @@ local function calculateMirage(env, config)
newSkill.skillCfg.skillCond["usedByMirage"] = true
newSkill.skillData.limitedProcessing = true
newSkill.skillTypes[SkillType.OtherThingUsesSkill] = true
env.player.mainSkill.mirage = { }
env.player.mainSkill.mirage.name = newSkill.activeEffect.grantedEffect.name

_ = config.preCalcFunc and config.preCalcFunc(env, newSkill, newEnv)

newEnv.player.mainSkill = newSkill
Expand All @@ -63,7 +62,11 @@ function calcs.mirages(env)
local moreDamage = newSkill.skillModList:Sum("BASE", newSkill.skillCfg, "MirageArcherLessDamage")
local moreAttackSpeed = newSkill.skillModList:Sum("BASE", newSkill.skillCfg, "MirageArcherLessAttackSpeed")
local mirageCount = newSkill.skillModList:Sum("BASE", env.player.mainSkill.skillCfg, "MirageArcherMaxCount")

env.player.mainSkill.mirage = { }
env.player.mainSkill.mirage.name = newSkill.activeEffect.grantedEffect.name
env.player.mainSkill.mirage.count = mirageCount

if not env.player.mainSkill.infoMessage then
env.player.mainSkill.infoMessage = tostring(mirageCount) .. " Mirage Archers using " .. newSkill.activeEffect.grantedEffect.name
end
Expand All @@ -81,9 +84,7 @@ function calcs.mirages(env)
end
end,
postCalcFunc = function(env, newSkill, newEnv)
-- Re-link over the output
env.player.mainSkill.mirage.output = newEnv.player.output

if newSkill.minion then
env.player.mainSkill.mirage.minion = {}
env.player.mainSkill.mirage.minion.output = newEnv.minion.output
Expand Down