Fix rare bug affecting allocating imported cluster nodes #6701
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Sep 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
Mastery nodes always get and index of 0. Some nodes on cluster jewel could also have an index of 0. Rarely, if Lua happened to iterate through the nodes and reached the mastery node first, it'd try to allocate it and fail, exiting the loop entirely. Imported nodes should never contain a mastery node for a cluster jewel, so this check was just checking the wrong node for if it's a mastery or not. This PR corrects that change.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
No link applicable, because it only happens on character import. This was one example, but you may have to ask them to reallocate nodes, as their character has changed since testing: gladvold -> diyu_chiefGoBoom