Fix Honoured Tattoo of the Tuatara interaction with Stat Conversion jewels #6712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Sep 20, 2023
3 tasks
shafouz
pushed a commit
to shafouz/PathOfBuilding
that referenced
this pull request
Dec 8, 2023
…ewels (PathOfBuildingCommunity#6712) * check if node is tattoo for attr convert jewels * account for other tattoos that can be converted, like cold res
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6708
Description of the problem being solved:
Stat convert jewels are taking the +4 of the tattoo and treating like +4 of each, converting whichever applicable. This PR changes the stat convert jewels to ignore stat tattoo nodes. Timeless jewels are still adding stats to the nodes. This should only affect stat conversion. Other conversion jewels like Green Nightmare should affect tattoos as before.
Other Ways to Implement:
I thought about adding another field to getSimpleConv and passing true or whatever for the 3 stats when parsed to use in the conditional. Or could check the type of "BASE" as I think that's only parsed by these stat conversion jewels for this function. If you see a cleaner way, lemme know.
Link to a build that showcases this PR:
Before screenshot:
Efficient Training:
After screenshot:
Efficient Training:
Lethal Pride:
Green Nightmare:
