Fix order of calcs for afflication charges #6801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Dec 1, 2023
LocalIdentity
pushed a commit
that referenced
this pull request
Dec 5, 2023
The block was moved in #6801 and this caused the code to not run in time
LocalIdentity
added a commit
that referenced
this pull request
Dec 5, 2023
The block was moved in #6801 and this caused the code to not run in time Co-authored-by: LocalIdentity <localidentity2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6788
Description of the problem being solved:
Due to affliction charge mods being added after ailment calcs, effect mods from affliction charges were not taken in account.
This pr moves affliction charge mods block into the
doActorMiscfunc and moves the calls for player and minion actors above the ailment calcs. While to my current understanding this should not break anything it should be tested at least a bit more before merging.Steps taken to verify a working solution: