Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update against damage over time to apply the modFlag directly #6805

Merged

Conversation

Regisle
Copy link
Member

@Regisle Regisle commented Oct 11, 2023

Fixes #3136

The config option for this doesnt make much sense, as we can just automatically apply it for damage over time, and anything which cares about the resistances (eg chaos resistance) never cared about the value vs damage over time
The sources of this was mainly underground mods

["DelveBodyArmourChaosDegenResist1"] = { type = "Suffix", affix = "of the Underground", "+(30-40)% Chaos Resistance against Damage Over Time", statOrderKey = "5149", statOrder = { 5149 }, level = 1, group = "ChaosResistanceAgainstDamageOverTime", weightKey = { "abyss_jewel", "jewel", "body_armour", "shield", "quiver", "default", }, weightVal = { 0, 0, 2000, 2000, 2000, 0 }, weightMultiplierKey = { }, weightMultiplierVal = { }, modTags = { "chaos", "resistance" }, },
or the pantheon, or a craft on belt
{ type = "Suffix", affix = "of Craft", modTags = { "chaos", "resistance" }, "+(31-36)% Chaos Resistance against Damage Over Time", statOrder = { 5149 }, level = 30, group = "ChaosResistanceAgainstDamageOverTime", types = { ["Belt"] = true, }, },
{ type = "Suffix", affix = "of Craft", modTags = { "chaos", "resistance" }, "+(37-43)% Chaos Resistance against Damage Over Time", statOrder = { 5149 }, level = 60, group = "ChaosResistanceAgainstDamageOverTime", types = { ["Belt"] = true, }, },

This also updates the enemy versions and I have tested a few of them including chieftains Ramako, Sun's Light

@Paliak Paliak added the bug: calculation Numerical differences label Oct 27, 2023
@LocalIdentity LocalIdentity merged commit 6eea10d into PathOfBuildingCommunity:dev Dec 1, 2023
@Regisle Regisle deleted the againstDamageOverTime branch December 1, 2023 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify "Are you against Damage over Time?" config option
3 participants