Fix timeless jewel devotion filter generation #6858
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the problem being solved:
If you select devotion modifiers on Militant Faith, then switch to a different jewel type (such as Brutal Restraint), generate any search results, and try to copy trade URL, it throws the following error:
This happens because the current
TreeTab.lua
tries to generatedevotionFilters
based ondevotionVariant1
/devotionVariant2
being set — which is necessary to check, but doesn't actually imply thatdata.timelessJewelTradeIDs[timelessData.jewelType.id].devotion
is usable.Steps taken to verify a working solution:
Before this PR the above error will occur, after this PR the Copy Trade URL button works as expected for all jewel types.
Link to a build that showcases this PR: