Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix timeless jewel devotion filter generation #6858

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

Lothrik
Copy link
Contributor

@Lothrik Lothrik commented Nov 5, 2023

Description of the problem being solved:

If you select devotion modifiers on Militant Faith, then switch to a different jewel type (such as Brutal Restraint), generate any search results, and try to copy trade URL, it throws the following error:

This happens because the current TreeTab.lua tries to generate devotionFilters based on devotionVariant1 / devotionVariant2 being set — which is necessary to check, but doesn't actually imply that data.timelessJewelTradeIDs[timelessData.jewelType.id].devotion is usable.

Steps taken to verify a working solution:

  • Create new build
  • Open Timeless Jewel Finder
  • Select Militant Faith Jewel Type
  • Select any Devotion Modifiers
  • Select any non-Militant Faith Jewel Type
  • Add any desired nodes and search (to populate the search results)
  • Copy Trade URL

Before this PR the above error will occur, after this PR the Copy Trade URL button works as expected for all jewel types.

Link to a build that showcases this PR:

eNqtW-1T2zgT_9z7Kzz-fCXEeQFuwt0EApQZKHkS2t59YhRbSVRkKSfLQO6vf1aSnZg0MnLsTgecaH_7Ju1qdxMGf73F1HvBIiGcnfvto2PfwyzkEWGLc__b4_XnU_-vP38bjJFcPswvUkLVyp-_fRroZ4_iF0wB53sSiQWW33NOnSfgtEJMLjFn9-gnFzc8Ove_coZ9b4ZYRGT-KqQoSb6iGJ_70xDAvoeSELPocvt-RrhEAoUSizsldZhKfs8jWJUihdUYETbl4TOWN4KnK63UC8Gvhub2fvwweSyoRFhRJbDo02BM0RqLqUTSS-DHuT8Ex6AFHqEYfgI3RFOsnHR62jtpdwP9s-O3SsEXqUjkYRymK4yjAiiwEY4FvprPcSjJC74URF4uEQu34o5tuKq09ymVZEUJFgWtejbEl1-Yn53ZaB-5RHQ0nm5Ig6OgH2ydVI7j8mP9fxC5vKDg0AOkKOztghGJDwSPOUk4q2FfEWrfopRSiE4n2glOsHhBkrxXy86bxzPCDvLePWLokicOe6Qox1hA8MtKgCkOOeSLqjIqIu_IHLtTVrIjA1TV5jA7rqaudJUZH6bQBHKjG-WUp9SRUm5zVGClGuE3B6pbJp14vXCpr6-PdNNBffVlvKHsnR21253O8XH3LOi3rYE0Xq4TEiJ6j95InMaQXx_RM94K7JcclsVSMsgNNmjn1Aa9JgJXR11yGh2AWiKeVIepUHBwAlyn4R-K9paFbvH1jQmdJgu3cL8UMIFTr679GcWOiK2ILHa2N-vxB6IWmGXy1m7m3GEcLm-gTJogid0y5faIlrtV0Tq5VRHucWvPEVDBSQpocdLRWRmoopuuGBaL9XRJMI2qUeeKXaKVQ0JTbi6indz9XlylE1OEVnTJDyQit7RfVacXlBRTbLtf7i5D7nYwMRSHAIiwa0U8FvynqrlpNdhQxDwVjhtuiJ0MyG8H02tMcJSGbtfRBYWuyVV70IrSSoihlCh8HvFogSsJqY6YpqsVJAq15a44dbtBKUwKJcXnvgP1A5xXp7BVF6G7gC21s4DN1e4uZQfibou6nisYsyV3FrFpY-8hI8SQ6XUPDC38NuStmwPdj1MrowkdW6oxfwXNl2q2kVSjhjJmW7pYVRGY_bd25v-O3EnAFYtSoULBWcYuYp-YRxJDtkySEZLI-4lfMX1cr_BtBPe470VZHfwdCYKYDNQl7RsqM55RdP3jkw7QJhiJcHkHJ-QaUTqDPHHuF98997HEgiH6xKBmhqrqKSYMeD8Fv3vt371j-A_kmus1oUA6ApBSXhm4q0kbqnffg7bk3xQLLnKVzYEatPRASz3dxisupIff1K8xEnJ97s8RTbAh1O8A70QSpvtnSHGU-t50yV-H0YuS_sg5TXKQh1YrzKJ3PB4Fxh7SB12leaWEdqx6UZx-Kf2O1WgrAdvWJjgS5SLGQQFw9-lpp-N7EtgVJm9BkA3VDFxx_jT4NrnTD5-WUq6SP1qt19fXoxWSSz7Hb3CHHYU8bq0ABDp9Tp4JpZ8V29YQ_l0shvqfZtTKOQ3MdiYt80rFuCCgljkjLWWLdqwyVj185RInak29mb8YTJWoBDZRyBscJxdriMtrVXPszBwybynqKZZ6uvcOk48BIzxHKVXv_y9FlKjNC46Lb9-ZkSXjIt60UsALdk_dH4alOhvg3uHdnVkZUplxU_LyrTRblmnkkcJZMkapx0tEQ2304JatUukxPc-MSRI-zdL5XA0nQYQUet56dX19dfl4-_0qi7MiRG_JE0vjmZq-md_bbDjF-rL3knSWmMdz_zvBr1qREZaI0ESdfUrRKsGbw6iVziyggCvhpqmgKctHmft5bQnsnK7esIDYWUCVGAqCrXpt1j9QyghUFaTKSzZuakhoZ2SKlEuIM1PhWjylB7J2LmpGajVHLZZgIesgapWcrX7gCamOLYQdmZNQpfTyLVeH3FCV-CUM4TYI1yX7nZVadh566mpjYBbtYDM5taGz1RKv6qmt1atm1Q4f4RBZbTeLdvCmaeIM3GTjsqEq4fSVM33IIWiGhKqyyLqzVxRvSOwMH-QSi-w6sXG6hxyVk5QGjiCzVNrDuEBR4is9wrF4SK3ZoWZMYbFBrZVkonetu8WhRRo7K9PyWhNZGdSUyFb_ZQV3yRZkDaXF_Wa1xAl5T22xP1suCRKdf4cvnESm6bKEyw5ZWcKAwqI-G91A1mez21rW53gNtdmzdb-zVTv8mySqEtnDxVRATkxUUNXjoGKrHofJbiGxxU7KSwidv0Z4jsHRpQlsQ1OyvzJlI7jkZMneOrLSau0PhK1plXiZVL7X0soczQHNhuplZ9iQfMAI7qIvJdWOG6dNu_8FI6o-JuW0HsNfPjyoZSeXCWLRSM0oaxqqRpzpCpjlmj3sK1e3W7rLddDKGwndO6rSPmuTp1KohvA_zuN_dLOonrIep5P1NVDkjQi4WugjkstRhH_nk4DBrYTOJuuy1HPeZKUJNp_l_cBoxZl-u9D-ZKQlZFljlLWMlEOnBJjxDNpI3cnq7uaGQv0OPlZLpmttlQOMGK9dAXLBYT-94WydJIh6pnn1elUYYCp38UEFvE6IXucAK73pK1rtiu4ewqiG-RmPoAEe-w3qN2BQvwGDDuKxz6Dap7PTgEeCpqypct6-YLi4ZC1_7Am2fm0NgsocaovsNOX_XgOHod1AeLQb0KNb8SQ0lWKCuhHZbcCB1e-MxlJsp679Qc0QrqZAtPZM_1rnDJraog6H_YHdq82h39S2tpvKMdWPZn0_dmvvZa-ZQ1XF-GGcUiwbyISdBhJKp2ZQdmvi2834_-CbsvKh7VZGHFJF1fRqr26ubmhbuk0ll8bq6oNbqAq4CWGLSlu4PzUFzexBYzdFEw1f9zCbqjq__h3fULHRq61I_SuuXzUZ1E0evwoctLJhj55H6XmR_oSbszlZ5F8mCfGS0wiLjDVmOF5nf8eSf2Z9UvzO5j764p-l5KDex5D8k-kc0vlATH4qc_ogsNInZEHow1x_v2cqkf4ize5H8BYp2dfxOKUTxIrqnXyg3uZzmRzQPykHvP8CYEFQPkHMNmrQ2v1rrv8D-Iw2pw==

@Lothrik Lothrik added the bug Something isn't working label Nov 5, 2023
@LocalIdentity LocalIdentity merged commit e8916ff into PathOfBuildingCommunity:dev Dec 1, 2023
2 checks passed
@Lothrik Lothrik deleted the fix-devotion branch December 1, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants