Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix channeled melee or attacks halving trigger rate when dual wielding #6894

Conversation

Lilylicious
Copy link
Contributor

Fixes issue from reddit post

Description of the problem being solved:

The check for dual wielding when dealing with channeled skills only checked for the skilltype being melee or attack. Channeled skills are not affected by dual wielding when it comes to their trigger rate.

Steps taken to verify a working solution:

  • Check trigger rate before and after fix
  • Confirm that the effective trigger rate is not halved when dual wielding with cyclone after fix

Link to a build that showcases this PR:

https://pobb.in/t0VBjjT1jhEJ (has massively increased CDR in custom mods to allow for always fully capped trigger rate)

@LocalIdentity LocalIdentity added the bug: calculation Numerical differences label Dec 3, 2023
@LocalIdentity LocalIdentity merged commit 638a4dc into PathOfBuildingCommunity:dev Dec 3, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug: calculation Numerical differences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants