-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3.23 More skills #6897
Merged
LocalIdentity
merged 24 commits into
PathOfBuildingCommunity:fix_3.23-gem-changes
from
Lilylicious:moreSkills
Dec 4, 2023
Merged
3.23 More skills #6897
LocalIdentity
merged 24 commits into
PathOfBuildingCommunity:fix_3.23-gem-changes
from
Lilylicious:moreSkills
Dec 4, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LocalIdentity
approved these changes
Dec 4, 2023
LocalIdentity
added a commit
that referenced
this pull request
Dec 4, 2023
* Arc + Vaal Arc * Blade Vortex + Vaal Blade Vortex * Bladefall * Cobra Lash * Cold Snap + Vaal Cold Snap * Divine Ire * Dual Strike * Crackling Lance * Freezing Pulse * Ice Nova + Vaal Ice Nova * Kinetic Blast * Penance Brand * Righteous Fire * Splitting Steel * Spell Echo * Vortex * Update experimental base types * Fix Cobra Lash * Update Vortex mana costs * Ice Crash * Power Siphon + Vaal Power Siphon * 3.23 More skills (#6897) * Update all Golems * Summon Holy Relic * Static Strike * Split Arrow * Spellslinger * Spectral Shield Throw * Spectral Throw * Spectral Helix * Spark * Cyclone * Boneshatter * Double Strike * Discharge * General's Cry * Glacial Cascade * Explosive Trap * Frenzy * Ice Spear * Lightning Conduit * Fix Discharge tooltip and .txt * Update Cyclone radius * Fix old stat interpolations * Fix discharge AoE stacking * Fix Double Strike + Vaal Cyclone --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> --------- Co-authored-by: LocalIdentity <localidentity2@gmail.com> Co-authored-by: Lily <Lilylicious@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A bunch more gem changes for 3.23
General's Cry tooltip for the quality is scuffed, but it doesn't affect the outcome. I suspect the stat descriptions for summoned per 5 MP and max number of warriors will be split in the patch.
This affects:
All Golems, though buff effect qualities seems to be broken on most of them
Summon Holy Relic
Static Strike
Split Arrow
Spellslinger
Spectral Shield Throw
Spectral Throw
Spectral Helix
Spark
Cyclone
Boneshatter
Double Strike
Discharge
General's Cry
Glacial Cascade
Explosive Trap
Frenzy
Ice Spear
Lightning Conduit