Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Call to Arms gem #7632

Merged
merged 1 commit into from
Jun 27, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Data/SkillStatMap.lua
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ return {
["cast_on_damage_taken_threshold"] = {
skill("triggeredByDamageTaken", nil, { type = "SkillType", skillType = SkillType.Triggerable }, { type = "SkillType", skillType = SkillType.Spell }),
},
["support_autocast_warcries"] = {
skill("triggeredByAutoCry", nil, { type = "SkillType", skillType = SkillType.Triggerable }, { type = "SkillType", skillType = SkillType.Warcry }),
},
["cast_on_stunned_%"] = {
skill("chanceToTriggerOnStun", nil, { type = "SkillType", skillType = SkillType.Triggerable }, { type = "SkillType", skillType = SkillType.Spell }),
},
Expand Down
5 changes: 5 additions & 0 deletions src/Data/Skills/sup_str.lua
Original file line number Diff line number Diff line change
Expand Up @@ -735,6 +735,11 @@ skills["CallToArms"] = {
description = "While this skill is active, a supported warcry will be repeatedly triggered, and all your warcry skills will share cooldowns.",
skillTypes = { [SkillType.Spell] = true, [SkillType.Instant] = true, [SkillType.HasReservation] = true, [SkillType.Cooldown] = true, },
statDescriptionScope = "skill_stat_descriptions",
statMap = {
["call_to_arms_behaviour"] = {
-- Display only
}
},
castTime = 0,
baseFlags = {
},
Expand Down
5 changes: 5 additions & 0 deletions src/Export/Skills/sup_str.txt
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,11 @@ local skills, mod, flag, skill = ...
#mods

#skill CallToArms
statMap = {
["call_to_arms_behaviour"] = {
-- Display only
}
},
#mods

#skill SupportCallToArms
Expand Down
13 changes: 13 additions & 0 deletions src/Modules/CalcTriggers.lua
Original file line number Diff line number Diff line change
Expand Up @@ -1089,6 +1089,19 @@ local configTable = {
return isWandAttack and not skill.skillData.triggeredBySpellSlinger
end}
end,
["call to arms"] = function(env)
if env.player.mainSkill.activeEffect.grantedEffect.name == "Call to Arms" then
env.player.mainSkill.skillFlags.globalTrigger = true
return {source = env.player.mainSkill}
end
env.player.mainSkill.skillData.sourceRateIsFinal = true
env.player.mainSkill.skillData.ignoresTickRate = true
return {triggerOnUse = true,
useCastRate = true,
triggerSkillCond = function(env, skill)
return skill.activeEffect.grantedEffect.name == "Call to Arms"
end}
end,
["mark on hit"] = function()
return {triggerSkillCond = function(env, skill) return skill.skillTypes[SkillType.Attack] end}
end,
Expand Down
Loading