Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for inc brand aoe after 50% attached duration mastery #7683

Conversation

Nerotox
Copy link
Contributor

@Nerotox Nerotox commented Jul 14, 2024

Description of the problem being solved:

Adds support for the "Brands have 30% increased Area of Effect if 50% of the Attached Duration expired" brand mastery.

Adds a new config "Last 50% of attached duration?", similar to the current 25% from from the heiro ascendancy.

AoE only applies to brands -> had to introduce small changes to the AoE calc to support brand specific AoE modifiers. The inc. AoE mod is still shown in the breakdown for non-brands but it is not applied. If s1 has a clue on how to have a skill type condition in the CalcSections.lua feel free to comment.
E.g. Toxic Rain:
image

Steps taken to verify a working solution:

  • Select a brand skill with a radius (e.g. arma brand)
  • Spec the 30% aoe if 50% expired brand mastery
  • Enable the "Last 50% of attached duration?" config
  • AoE calcs should have 30% inc aoe for all radii (primary, secondary, tertiary).
  • If a normal skill is selected then the AoE will not apply (e.g. toxic rain)

Link to a build that showcases this PR:

https://pobb.in/UTuU9CKlmVuY

Before screenshot:

image

After screenshot:

image
image

@LocalIdentity LocalIdentity added the enhancement New feature, calculation, or mod label Jul 14, 2024
You don't need to add specific handling for different skill types you can just use a skillType check on the mod in ModParser and the rest will be handled
@LocalIdentity
Copy link
Contributor

LocalIdentity commented Jul 14, 2024

@Nerotox I fixed the PR in my latest commit. When you're adding a mod that applies to a whole skill type you can just add a SkillType check in ModParser and the AoE component will be handled correctly by the existing code
Thanks for the first time contribution, feel free to join our Discord. Send me a message (LocalIdentity)

@LocalIdentity LocalIdentity merged commit 4b58632 into PathOfBuildingCommunity:dev Jul 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature, calculation, or mod
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants