Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by invalid impossible escape keystone #7731

Merged
merged 1 commit into from
Jul 21, 2024

Conversation

trimbe
Copy link
Contributor

@trimbe trimbe commented Jul 20, 2024

Fixes #7728

The test variant is generated with conquered keystones, which aren't present in the keystoneMap (and aren't actual mods).

@Paliak Paliak added the crash Causes PoB to crash and is High Priority label Jul 20, 2024
@Mysrt
Copy link

Mysrt commented Jul 20, 2024

If you're like me and bricked your build with this and want to keep working on it go to:

C:\Users<Username>\Documents\Path of Building\Builds<find your build>

  • edit the file with notepad/whatever text editor
  • ctrl+f for the <Sockets> node
  • Delete everything in that node
  • save
  • should be able to open your build again.
  • don't use the jewel again till this is merged in

Copy link
Member

@Wires77 Wires77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably not generate that jewel with conquered keystones, but this is a fine fix for it too.

@Wires77 Wires77 merged commit 459d5bb into PathOfBuildingCommunity:dev Jul 21, 2024
2 checks passed
@trimbe
Copy link
Contributor Author

trimbe commented Jul 21, 2024

I agree, I'll look into making that generation more robust as well.

@trimbe trimbe deleted the test-variant-escape branch July 22, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crash Causes PoB to crash and is High Priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impossible Escape QoL test variant is broken in beta
4 participants