Fix item quality not defaulting to 20% #8032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7966 .
Description of the problem being solved:
Due to an incorrect If statement regarding setting quality to nil for Amulets, Belts, etc, items that should have quality set to 20 by default were going into NormaliseQuality() with a nil value for quality, causing it to get set to 0 by default.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
NA
Before screenshot:
Amulet Example:
Body Armour Example:
After screenshot:
Amulet Example:
Body Armour Example:
Additional Note:
This code still relies on NormalizeQuality() to properly set the default value from 0 to 20 in cases where a default quality is expected. I think it would be pertinent to remove the reliance CraftItem() has on NormalizeQuality() to properly set the default values, unless this behavior is intentional. I can look into this decoupling further if desired.