Fix Herald of Ash overkill damage incorrectly scaling with global damage increases #8330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calculations fixed, mod inc display edge case issue.
Jonathan-Dang
changed the title
Jonathan-Dang
changed the title
LocalIdentity
approved these changes
Nov 18, 2024
LocalIdentity
merged commit 239aeb2
into
PathOfBuildingCommunity:dev
1 of 2 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculations fixed, mod inc display edge case issue.
Fixes #8261 .
Description of the problem being solved:
Calculations of Herald of Ash pulled from all sources of Fire damage over time increases, including but not limited to Global Fire damage increases when not supposed to.
Steps taken to verify a working solution:
Link to a build that showcases this PR:
https://pobb.in/vwANN9PgixQd
Before screenshot:
After screenshot: