Skip to content

Conversation

@ALameLlama
Copy link

Description of the problem being solved:

nodeId is always nil here since nodeId isn't in the scope of the loop. I think this might have been copied from above where we do this:

for nodeId, node in pairs(self.build.spec.nodes) do

In this loop we have nodeName but I don't think this is the correct thing to use and node.id seem to be working.

Steps taken to verify a working solution:

  • open power report
  • select full DPS
  • select show unallocated & clusters

Link to a build that showcases this PR:

N/A

Before screenshot:

image

After screenshot:

image

I guess this is more of a potential performance improvement since it'll be doing less uneeded work.

nodeId is out of scope of this loop and is always nil
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant