Enable the client to reflect the PC URL used by the server. #1457
Conversation
|
This isn't a general solution, e.g. |
There was a problem hiding this comment.
Looks good, thank you!
PS (somewhat off-topic:
Before v4.0.0 release of this app for PC v14 backend (new app-ui will not completely work with the older versions/data anymore due to some env/config changes and using bioregistry.io instead of identifiers.org, etc.) -
- can we make sure we have correct Dockerfile for prod (I bet we do not need imges for dev use anyway...). Is this line there still correct:
RUN NODE_ENV=development npm ci(I guess NODE_ENV is not needed or must be production, as we do not want any dev modules/dependencies in docker images, and it should benpm installinstead of ci.. but I am not sure)? - check/polish Readme as well...
- do we really want that "Syblars" and cli.js be part of this web app or those could be separated into another Git repo perhaps?
| @@ -1,5 +1,5 @@ | |||
| const _ = require('lodash'); | |||
| const logger = require('../../logger'); | |||
| // const logger = require('../../logger'); | |||
There was a problem hiding this comment.
If we do not need logger in this file, then let's remove this line instead of commentig it out...
| @@ -4,6 +4,11 @@ const pc = require('../external-services/pathway-commons'); | |||
|
|
|||
| const router = express.Router(); | |||
|
|
|||
| const { PC_URL } = require('../../config'); | |||
|
|
|||
| router.get('/baseURL', function (req, res) { | |||
There was a problem hiding this comment.
I like this - so it will use the PC_URL env property set at runtime for both server and client side now.
|
@jvwong , unlike FACTOID_URL, which is only used by the server-side/backend (client calls webapp's /api/biofactoid proxy instead of calling biofactoid api directly), PC_URL was used both from backend and client side. There was just one use case - downloading data in varios formats directly from PC ws as saving as files - where PC_URL was used from the client. I think there is something wrong about |
Retrieve the PC_URL from the server endpoint, cache in client.
Refs: #1456