Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements and fixes for Android app #336

Closed
PatilShreyas opened this issue Nov 18, 2021 Discussed in #330 · 0 comments · Fixed by #331
Closed

Improvements and fixes for Android app #336

PatilShreyas opened this issue Nov 18, 2021 Discussed in #330 · 0 comments · Fixed by #331
Labels
enhancement New feature or request
Milestone

Comments

@PatilShreyas
Copy link
Owner

Discussed in #330

Originally posted by kasem-sm November 17, 2021
Fixes:

  • Crash when user clicks log out button (simpleapp) ((simpleapp) App Crashes when user click's Log Out. #329 ).
  • Fixed view state does not resets after Success or Error state (guided by @PatilShreyas).
  • Replaced lifecycleScope.launch with viewLifecycleOwner.lifecycleScope here (probably added by mistake).
  • Fix Save Note button hides behind the keyboard (composeapp) by adding windowSoftInputMode attribute in manifest.

Improvements:

  • Added confirmation dialog while logging out and deletion of a note. (simpleapp).
  • Fix Save Note button hides behind the keyboard (composeapp).
  • wrapped all action Icon composable inside of IconButton at NotyActions (for a better touch region).
  • Changed scaffold background color at AboutScreen to match with the background color at NoteDetailScreen.
  • Changed navigation (back) icon drawable at AboutScreen to match with the icon at NoteDetailScreen.
  • Changed the text style and padding at NoteTextFields at composeapp to match the styles and padding of simpleapp.
  • Refactored NotyDialogs's ConfirmationDialog to use Default AlertDialog composable instead of Default Dialog composable.
@PatilShreyas PatilShreyas linked a pull request Nov 18, 2021 that will close this issue
5 tasks
@PatilShreyas PatilShreyas added this to the v1.3.2 milestone Nov 18, 2021
@PatilShreyas PatilShreyas added the enhancement New feature or request label Nov 18, 2021
@PatilShreyas PatilShreyas moved this to Done in NotyKT Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant