Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(simpleapp) App Crashes when user click's Log Out. #329

Closed
kasem-sm opened this issue Nov 17, 2021 · 2 comments · Fixed by #331
Closed

(simpleapp) App Crashes when user click's Log Out. #329

kasem-sm opened this issue Nov 17, 2021 · 2 comments · Fixed by #331
Assignees
@kasem-sm
Labels
bug Something isn't working
Milestone
v1.3.2

Comments

@kasem-sm
Copy link
Contributor

Logcat and fix for this issue attached:

Logcat: Process: dev.shreyaspatil.noty.simpleapp, PID: 14678 java.lang.IllegalArgumentException: Navigation action/destination dev.shreyaspatil.noty.simpleapp:id/action_notesFragment_to_loginFragment cannot be found from the current destination Destination(dev.shreyaspatil.noty.simpleapp:id/loginFragment) label=fragment_login class=dev.shreyaspatil.noty.simpleapp.view.login.LoginFragment at androidx.navigation.NavController.navigate(NavController.java:940)

Fix: To check current destination before navigating.

I can contribute to this issue as well if @PatilShreyas assigns me 😅.
@PatilShreyas
Copy link
Owner

Sure @kasem-sm you can take this up

@PatilShreyas
Copy link
Owner

Assigning this to you

@PatilShreyas PatilShreyas added the bug Something isn't working label Nov 17, 2021
@PatilShreyas PatilShreyas modified the milestones: v1.3.1, v1.3.2 Nov 17, 2021
kasem-sm added a commit to kasem-sm/NotyKT that referenced this issue Nov 17, 2021
@kasem-sm
Fixes PatilShreyas#329. Multiple Fixes and Improvements as stated in P…
0bce0aa 
…atilShreyas#330
@PatilShreyas PatilShreyas mentioned this issue Nov 18, 2021
Closed
@PatilShreyas PatilShreyas linked a pull request Nov 18, 2021 that will close this issue
Fixes #329. Multiple Fixes and Improvements as stated in #330 #331
Merged
5 tasks
PatilShreyas added a commit that referenced this issue Nov 19, 2021
@PatilShreyas
Merge pull request #331 from kasem-sm/multiple_fixes_and_improvements
21b0073 
Fixes #329. Multiple Fixes and Improvements as stated in #330
@PatilShreyas PatilShreyas moved this to Done in NotyKT Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kasem-sm kasem-sm

Labels
bug Something isn't working
Projects
NotyKT
Status: Done
Milestone
v1.3.2
Development

Successfully merging a pull request may close this issue.

Fixes #329. Multiple Fixes and Improvements as stated in #330 kasem-sm/NotyKT
2 participants
@PatilShreyas @kasem-sm