chore(Conventions): naming standards #196
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #185
I'm not saying merge this actually, however this is how the naming conventions would play out here.
I've had mixed feelings about them for awhile but in general, like them.
I've just never been a big fan of long filenames which is why I'm not in love with
whatever.component.ts
vs.whatever.ts
, however it does make things clear.This becomes more idiomatic when you consider most conventions suggest placing files inside a folder called
components
such as shown here in this PR.So when opening files and you see:
app/components/home/home.component.ts
vs.
app/home/home.ts
First, for large projects with more than 2-3 nested hierarchies, you would need a screen or IDE at least wide enough to show the long path and filename when you have multiple tabs open to discern the difference between 2 of the same named files in different folders, ie.:
app/component/home/home.component.ts
vs.
app/component/users/profile/home.component.ts
^ just an example but it can definitely happen ;)
But in the end, I digress. Whatever the community believes is universally great.
If this is the way to go, then by all means, merge 👍