Add step plot #27
Add step plot #27
Conversation
|
@gjeusel : Hi, great to head that you like working with Pandas Bokeh. I find it amazing that you added a completely new plottype !!! thanks a lot. There is no contribution guideline, because I just started the project on my own and didn't think that anyone would like to contribute to it 😄. In my opinion, there should be 3 things for a successfull PR:
The development was not test-driven, which you can see in the code right now and I know that it needs a huge amount of refactoring 😞 , but I barely have time to even maintain the project with changes happening in Pandas and Bokeh. Did you already run the tests (just Tests/test_PandasBokeh.py with pytest is enought)? Cheers, Patrik |
| Either the location or the label of the columns to be used. | ||
| By default, it will use the remaining DataFrame numeric columns. | ||
| **kwds | ||
| Keyword arguments to pass on to :meth:`pandas.DataFrame.plot_bokeh`. |
There was a problem hiding this comment.
Keyword arguments to pass on to :meth:pandas.DataFrame.plot_bokeh and further to bokeh.plotting.figure.step
| y : int, str, or list of them, optional | ||
| The values to be plotted. | ||
| Either the location or the label of the columns to be used. | ||
| By default, it will use the remaining DataFrame numeric columns. |
There was a problem hiding this comment.
maybe also add the mode keyword here, because this seems to be very specific and important for a stepplot.
| The following example shows the populations for some animals | ||
| over the years. | ||
|
|
||
| >>> df = pd.DataFrame({ |
|
@gjeusel : Sorry for replying so late. I already answered you a week ago, but apparently my message was not sent :(. I will now merge your request and also add your Name to the CONTRIBUTORS.md file. Do you want to have your clear name as a contributor or your alias? |
Hello there ! I just love this project, here is my first PR.
I haven't found any contribution guideline, tell me how I can help ! ;)