Skip to content

Commit

Permalink
Patch ron version (gfx-rs#1986)
Browse files Browse the repository at this point in the history
Require at least version 0.7.1 of ron, this version changed how floating points are
serialized by forcing them to always have the decimal part, this makes it backwards
incompatible with our tests because we do a syntatic diff and not a semantic one.
  • Loading branch information
JCapucho authored Jun 15, 2022
1 parent 98bc8fe commit 357da63
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,10 @@ unicode-xid = { version = "0.2.3", optional = true }
bincode = "1"
criterion = { version = "0.3", features = [] }
diff = "0.1"
ron = "0.7"
# Require at least version 0.7.1 of ron, this version changed how floating points are
# serialized by forcing them to always have the decimal part, this makes it backwards
# incompatible with our tests because we do a syntatic diff and not a semantic one.
ron = "~0.7.1"
serde = { version = "1.0", features = ["derive"] }
spirv = { version = "0.2", features = ["deserialize"] }
rspirv = "0.11"
Expand Down
6 changes: 3 additions & 3 deletions tests/out/ir/shadow.ron
Original file line number Diff line number Diff line change
Expand Up @@ -324,15 +324,15 @@
specialization: None,
inner: Scalar(
width: 4,
value: Float(0),
value: Float(0.0),
),
),
(
name: None,
specialization: None,
inner: Scalar(
width: 4,
value: Float(1),
value: Float(1.0),
),
),
(
Expand Down Expand Up @@ -400,7 +400,7 @@
specialization: None,
inner: Scalar(
width: 4,
value: Float(0),
value: Float(0.0),
),
),
(
Expand Down

0 comments on commit 357da63

Please sign in to comment.