Fix more pat-bumper regressions #1098
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the viewport as scrolling container paddings and margins are not influencing the sticky element's position. This is contrary to other scrolling containers within the document. The position calculation is easier and only consists of the clientWidth/Height to respect scrollbar widths.
Following the sticky position specification only top, right, bottom and left values are used to compute the position relative to the scrolling container.
The container and element positions need to be calculated every time, as they are likely to be changed by dynamically assigned classes. This can be the case for different position values based on the scrolling direction classes set by pat-scroll-box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up from: #1094
Fixes: #1083